Refactor imports to PascalCase aliases and update docs#145
Refactor imports to PascalCase aliases and update docs#145fkarg wants to merge 3 commits intopgvector:masterfrom
Conversation
Closes pgvector#142 SQLModel SQLAlchemy ArgumentError when using HalfVector instead of Vector
|
Hi @fkarg, the SQLAlchemy convention is to use uppercase for non-generic types. When The You're welcome to fork and make any changes you'd like, but please stopping submitting PRs for this (it isn't contributing positively to the project). |
|
I didn't know about this, sorry for the confusion. I was hoping to increase consistency and help others unintentionally importing non-sqlalchemy types here, but yeah I understand that that would actually be a breaking change (though I doubt with many practical users). Don't worry, I wanted to help out, but clearly my attempts here were misguided. If I do end up submitting another PR it'll be about something else entirely, but no promises ;) |
Make available types and imports consistent with those (in PascalCase) available for other database libraries.