Skip to content

Fix GH-20914: Set default_object_handlers when registering internal enum #20915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arnaud-lb merged 2 commits into from
Jan 13, 2026
Merged

Fix GH-20914: Set default_object_handlers when registering internal enum #20915

arnaud-lb merged 2 commits into from
Jan 13, 2026

Conversation

@arnaud-lb
Copy link
Member

@arnaud-lb arnaud-lb commented Jan 12, 2026

Fixes GH-20914

TimWolla
TimWolla reviewed Jan 12, 2026
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems right. Since internal enums seem to have an entirely different code path, should we also test some other things:

  • Dynamic properties must be disallowed.
  • The interfaces should be implemented (UnitEnum / BackedEnum + any other interfaces listed in the stub file)

@arnaud-lb arnaud-lb changed the base branch from master to PHP-8.4 January 12, 2026 18:09
@arnaud-lb arnaud-lb marked this pull request as ready for review January 12, 2026 19:01
@arnaud-lb arnaud-lb requested a review from kocsismate as a code owner January 12, 2026 19:01
@TimWolla TimWolla mentioned this pull request Jan 12, 2026
Open
@arnaud-lb arnaud-lb merged commit 075b6b8 into php:PHP-8.4 Jan 13, 2026
10 checks passed
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

AWS x86_64 (c7i.24xl)

Attribute Value
Environment aws
Runner host
Instance type c7i.metal-24xl (dedicated)
Architecture x86_64
CPU Intel(R) Xeon(R) Platinum 8488C, 48 cores @ 2400 MHz
CPU settings disabled deeper C-states, disabled turbo boost, disabled hyper-threading
RAM 188 GB
Kernel 6.1.158-178.288.amzn2023.x86_64
OS Amazon Linux 2023.9.20251117
GCC 14.2.1
Time 2026-01-14 08:06:37 UTC

Laravel 12.11.0 demo app - 100 consecutive runs, 50 warmups, 100 requests (sec)

PHP Min Max Std dev Rel std dev % Mean Mean diff % Median Median diff % Skew P-value Memory
PHP - baseline@2a2e 0.46303 0.46562 0.00047 0.10% 0.46378 0.00% 0.46369 0.00% 1.342 0.999 27.44 MB
PHP - gh20914 0.46294 0.47039 0.00081 0.17% 0.46388 0.02% 0.46369 -0.00% 5.555 0.525 27.44 MB

Symfony 2.8.0 demo app - 100 consecutive runs, 50 warmups, 100 requests (sec)

PHP Min Max Std dev Rel std dev % Mean Mean diff % Median Median diff % Skew P-value Memory
PHP - baseline@2a2e 0.75021 0.76300 0.00201 0.27% 0.75262 0.00% 0.75194 0.00% 2.897 0.999 27.46 MB
PHP - gh20914 0.75110 0.76268 0.00135 0.18% 0.75260 -0.00% 0.75234 0.05% 4.613 0.005 27.45 MB

Wordpress 6.9 main page - 100 consecutive runs, 20 warmups, 20 requests (sec)

PHP Min Max Std dev Rel std dev % Mean Mean diff % Median Median diff % Skew P-value Memory
PHP - baseline@2a2e 0.66464 0.67105 0.00071 0.11% 0.66610 0.00% 0.66598 0.00% 3.719 0.999 27.47 MB
PHP - gh20914 0.66542 0.68501 0.00268 0.40% 0.66666 0.08% 0.66621 0.03% 6.455 0.003 27.47 MB

bench.php - 100 consecutive runs, 10 warmups, 2 requests (sec)

PHP Min Max Std dev Rel std dev % Mean Mean diff % Median Median diff % Skew P-value Memory
PHP - baseline@2a2e 0.41981 0.42767 0.00162 0.38% 0.42273 0.00% 0.42269 0.00% 0.522 0.999 7.95 MB
PHP - gh20914 0.42021 0.42735 0.00137 0.33% 0.42266 -0.02% 0.42250 -0.04% 0.915 0.751 7.95 MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimWolla TimWolla TimWolla approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees

No one assigned

Labels

Category: Engine Extension: zend_test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Internal enums can be cloned and compared

2 participants

@arnaud-lb @TimWolla