Skip to content

Incorrect SOCKETS_G(wsa_info) memory deallocation Win32 #20940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
EdmondDantes wants to merge 2 commits into
base: PHP-8.5.1
Choose a base branch
from
Open

Incorrect SOCKETS_G(wsa_info) memory deallocation Win32 #20940

EdmondDantes wants to merge 2 commits into from
+8 −4

Conversation

@EdmondDantes
Copy link

@EdmondDantes EdmondDantes commented Jan 14, 2026 •
edited
Loading 

PHP_FUNCTION(socket_wsaprotocol_info_export)
{
 .....
        // allocate Request memory here
	seg_name = zend_strpprintf(0, "php_wsa_for_%u", SOCKETS_G(wsa_child_count)++);
	map = CreateFileMapping(INVALID_HANDLE_VALUE, NULL, PAGE_READWRITE, 0, sizeof(WSAPROTOCOL_INFO), ZSTR_VAL(seg_name));
	if (NULL != map) {

        // put to persistent memory array
        zend_hash_add_ptr(&(SOCKETS_G(wsa_info)), seg_name, map);

Memory allocated for the request is destroyed before the SOCKETS_G(wsa_info) array is destructed

If the socket_wsaprotocol_info_release method is not called, the application terminates with the message "zend_mm_heap corrupted"

The code proposed in this patch is not ideal, and it may be worth removing the creation of the array in persistent memory. I do not fully understand the reason why it was done this way. Nevertheless, this code works correctly.

P.S. Apparently, this bug is present in all PHP versions.

edorian and others added 2 commits December 16, 2025 16:59
@edorian
Update versions for PHP 8.5.1
3f6a5c8
@EdmondDantes
Fix WSA protocol info cleanup in request shutdown
86c96b4 
- Add zend_hash_clean() in PHP_RSHUTDOWN_FUNCTION to cleanup wsa_info
- Ensures all WSA HANDLE resources are properly closed at end of request
- Prevents resource leak when socket_wsaprotocol_info_release() is not called
@bukka
Copy link
Member

bukka commented Jan 14, 2026

@EdmondDantes please target PHP-8.5 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

Assignees

No one assigned

Labels

ABI break Category: Build System Category: Engine Extension: sockets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EdmondDantes @bukka @edorian