Show small note in export stating about invalid export files #19680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9bbda4 to
ac89949
Compare
Contributor
|
How does |
Author
If you happen to compress a table that surpasses the size, it would end up downloading a small 191 byte file which -when opened with a hex editor- would simply state: |
Contributor
|
Yes, so the error talks about |
Author
|
oh doh you're absolutely right hahaha I did previously look into the upload limit so totally forgot we had memory limit as well :) my bad! |
Shows up a small hint dialog explaining that compression uses PHP memory which can produce invalid files Signed-off-by: camilo <camilo@jouwweb.nl>
ac89949 to
758c8cd
Compare
williamdes
reviewed
Apr 28, 2025
| <label for="compression" class="col-form-label">{{ t('Compression:') }}</label> | ||
| <label for="compression" class="col-form-label"> | ||
| {{ t('Compression:') }} | ||
| {{ show_hint('Compressing big tables requires PHP memory. Be aware that this might produce invalid files %s'|format(get_formatted_maximum_upload_size(export_memory_limit))) }} |
Member
There was a problem hiding this comment.
Can you post a screenshot?
the sentence seems incomplete
Also, we could find a way to to figure out out of memory and abort the export
Member
There was a problem hiding this comment.
Suggested change
| {{ show_hint('Compressing big tables requires PHP memory. Be aware that this might produce invalid files %s'|format(get_formatted_maximum_upload_size(export_memory_limit))) }} | |
| {{ show_hint('Compressing big tables requires PHP memory. Be aware that this might produce invalid files. Current memory limit: %s'|format(get_formatted_maximum_upload_size(export_memory_limit))) }} |
williamdes
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While exporting tables using compression, we would sometimes get invalid files. We turned out to be hitting PHP maximum memory limit.
This commit will add a small non-obstrusive hint about that.
Fixes # -> (no issue made for it)
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.I did not create a test for this, since the change is purely cosmetic and doesn't fix anything.