Skip to content

Conversation

@kkmuffme
Copy link

Description

Fixes #19865

Additionally slightly improve the code.

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

@williamdes williamdes changed the title Fix ob header name Fix #19865 - ob header name Sep 18, 2025
@williamdes
Copy link
Member

Are you testing your changes on phpMyAdmin 6.0 or 5.2 ?

@kkmuffme
Copy link
Author

On 5.2, just as you told me on the issue

@williamdes
Copy link
Member

On 5.2, just as you told me on the issue

Okay, the pull request is not done from the QA_5_2 branch that's why I am asking

@M393
Copy link
Contributor

M393 commented Sep 18, 2025

@kkmuffme You need to change the merge target for this PR.

Click Edit in in the top-right of this page, then choose QA_5_2 in the dropdown under the heading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: X-ob_mode header should use hyphens

4 participants