Skip to content

Conversation

@faissaloux
Copy link
Contributor

Resolves #19945

@faissaloux faissaloux marked this pull request as ready for review December 15, 2025 11:21
Copy link
Contributor

@liviuconcioiu liviuconcioiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Also, you should update the code, since #19957 has been merged.

A few things:

Can you add this so it will be possible to change the separator and indent.

        $leaf = new TextPropertyItem(
            'separator',
            __('Columns separated with:'),
        );
        $generalOptions->addProperty($leaf);
        $leaf = new TextPropertyItem(
            'indent',
            __('Indent'),
        );
        $generalOptions->addProperty($leaf);

You should also make changes in src\Config\Settings\Export.php so the values can be seen when exporting and also be able to use them from config file

$cfg['Export']['toon_separator'] = '|';
$cfg['Export']['toon_indent'] = 4;

Also, can you add a small text to documentation import_export.rst - #export?

Thank you!

@williamdes williamdes added the Enhancement A feature request for improving phpMyAdmin label Dec 17, 2025
@faissaloux
Copy link
Contributor Author

@liviuconcioiu @williamdes indent and separator are now configurable.

Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Copy link
Contributor

@liviuconcioiu liviuconcioiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faissaloux I left some comments.

  1. Add support for tab as delimiter - https://toonformat.dev/playground.html
  2. Renamed from Toon to TOON

Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement A feature request for improving phpMyAdmin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for TOON file format

5 participants