Insufficient space export exception #20017
Open
+500
−914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
williamdes
reviewed
Jan 10, 2026
|
|
||
| $this->outputHandler->addLine( | ||
| '/**' . "\n" | ||
| . ' * Database ' . $this->commentString(Util::backquote($dbAlias)) |
Contributor
There was a problem hiding this comment.
This should be translatable?
Contributor
Author
There was a problem hiding this comment.
Maybe, but it's not really part of this PR.
| } | ||
| $this->outputHandler->addLine( | ||
| $tableAlias !== '' | ||
| ? '== ' . __('Dumping data for table') . ' ' . $tableAlias . "\n\n" |
Contributor
There was a problem hiding this comment.
Qustion: Here and in a few other places, shouldn't sprintf be used instead?
Suggested change
| ? '== ' . __('Dumping data for table') . ' ' . $tableAlias . "\n\n" | |
| ? '== ' . sprintf(__('Dumping data for table %s'), $tableAlias) . "\n\n" |
Contributor
Author
There was a problem hiding this comment.
Yeah, sounds good, but this PR is already huge, so maybe let's do it in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors all Export plugins. All methods now return void instead of bool. There were only two reasons when any of these methods would return false:
json_encodethe outputExportExceptionexception was reused to handle these two cases. In the next PR,json_encodehandling can be improved.