Replace request globals with ServerRequest object in Sql and Display\Results classes #20022
+133
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
approved these changes
Jan 13, 2026
| $db, | ||
| $table, | ||
| $request->getParsedBodyParamAsString('dropped_column', ''), | ||
| $request->hasBodyParam('purge'), |
Contributor
There was a problem hiding this comment.
Did you verify that the value doesn't matter? It could have been an empty string or "0" before.
| { | ||
| $output = ''; | ||
| if (isset($_GET['label'])) { | ||
| if ($label !== null && $label !== '') { |
Contributor
There was a problem hiding this comment.
Why the extra check for empty string?
| // If we are retrieving the full value of a truncated field or the original | ||
| // value of a transformed field, show it here | ||
| if (isset($_POST['grid_edit']) && $_POST['grid_edit']) { | ||
| if ($request->hasBodyParam('grid_edit')) { |
Contributor
There was a problem hiding this comment.
Was the part && $_POST['grid_edit'] unnecessary before?
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
393e619 to
6361e40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.