Closed
Conversation
If a filename extension and a format are specified with the same string, we create a file with a double file extension. Ie: ```javascript py.image.save_as(figure, 'filename2.png', 'png') ``` This will produce a file named filename2.png.png. When ext and format are both present, the fix will only append format to the filename if the format is different from ext. Ie: ```javascript py.image.save_as(figure, 'filename2.png', 'pdf') ``` This will create filename2.png.pdf.
Contributor
|
Apologies that this never got reviewed. It's pretty old at this point and I'm going to close down. If you want to rebase (or merge) master and reopen, I'll take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a filename extension and a format are specified with the same string,
we create a file with a double file extension. Ie:
This will produce a file named filename2.png.png. When ext and format
are both present, the fix will only append format to the filename if the
format is different from ext. Ie:
This will create filename2.png.pdf.