Fix template error bar coloring for bar plots#1643
Closed
Olof-Hojvall wants to merge 1 commit intoplotly:masterfrom
Closed
Fix template error bar coloring for bar plots#1643Olof-Hojvall wants to merge 1 commit intoplotly:masterfrom
Olof-Hojvall wants to merge 1 commit intoplotly:masterfrom
Conversation
Previous addition of bar outline in templates also changed error color
74be0c5 to
a22ffc5
Compare
Contributor
|
Thanks a lot for the report and fix @Olof-Hojvall. I just opened #1656 which has a small modification to your updates here, but built against the The modification I made is to set the error bar color to the template's font color. This way the same approach works for light and dark themes. See examples in the PR. Does that coloring approach work for you? |
Author
|
Thanks, that looks good. I’ll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous addition of bar outline in templates also changed color of error bars, since errorbar seems to use the colorof marker line over default. This shows a minimum change to fix it back, but I suspect that it would be preferably to set correct color it a better way. Would be happy to adjust the PR, if any suggestions on that could be done. Maybe something like default_line_color should be passed as argument like initialize_template(..., default_line_color=GRAY27) to allow templates to set the color of error bars.
See this notebooks for error and fix: https://nbviewer.jupyter.org/github/Olof-Hojvall/plotly.py/blob/error_bar_notebook/Bar%20Plot%20Errorbar%20Template%20Example.ipynb