Relax registry type annotations for exposition #1149
Merged
+25
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We require Python >= 3.9 now, so there's no reason to avoid this any more. Signed-off-by: Colin Watson <cjwatson@debian.org>
Anything with a suitable `collect` method will do: for instance, it's sometimes useful to be able to define a class whose `collect` method yields all metrics from a registry whose names have a given prefix, and such a class doesn't need to inherit from `CollectorRegistry`. Signed-off-by: Colin Watson <cjwatson@debian.org>
csmarchbanks
approved these changes
Nov 26, 2025
Member
csmarchbanks
left a comment
There was a problem hiding this comment.
Nice to see that old comment addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything with a suitable
collectmethod will do: for instance, it'ssometimes useful to be able to define a class whose
collectmethodyields all metrics from a registry whose names have a given prefix, and
such a class doesn't need to inherit from
CollectorRegistry.