Don't crash on malformed messages received with crypto enabled#291
Merged
wkal-pubnub merged 4 commits intomasterfrom Nov 20, 2023
Merged
Don't crash on malformed messages received with crypto enabled#291wkal-pubnub merged 4 commits intomasterfrom
wkal-pubnub merged 4 commits intomasterfrom
Conversation
parfeon
reviewed
Nov 13, 2023
wkal-pubnub
commented
Nov 13, 2023
marcin-cebo
reviewed
Nov 13, 2023
src/integrationTest/java/com/pubnub/api/integration/PublishIntegrationTests.java
Outdated
Show resolved
Hide resolved
405b02e to
382513c
Compare
382513c to
892eba9
Compare
marcin-cebo
approved these changes
Nov 15, 2023
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| log.trace("take message interrupted", e); | ||
| } catch (Exception e) { // don't crash the thread on malformed messages |
Contributor
There was a problem hiding this comment.
I am just wondering if this is needed anymore after changes in processMessage method ?
My understanding is that processMessage method handles malformed messages.
Contributor
Author
There was a problem hiding this comment.
yeah, I'd leave it in case there are errors in some other part of message processing, otherwise the whole message processing loop crashes
Deliver original message content with error flag.
892eba9 to
3532a26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.