Skip to content

Upgrade to Python 3.12.1#4435

Merged
hoodmane merged 115 commits intopyodide:mainfrom
hoodmane:python-3.12.1
Feb 4, 2024
Merged

Upgrade to Python 3.12.1#4435
hoodmane merged 115 commits intopyodide:mainfrom
hoodmane:python-3.12.1

Conversation

@hoodmane
Copy link
Member

@hoodmane hoodmane commented Jan 27, 2024

Resolves #4420.

  • Add a CHANGELOG entry
  • Add / update tests
  • Fix stack switching
  • sort through failing core Python tests

Packages with build failures

  • aiohttp
  • awkward-cpp
  • Cartopy
  • cbor-diag
  • cffi
  • coolprop
  • cramjam
  • cryptography
  • freesasa
  • gdal
  • gensim
  • igraph
  • kiwisolver
  • libmagic
  • libxml
  • multidict
  • opencv-python
  • orjson
  • pysam
  • pywavelets
  • sisl
  • swiglpk
  • wordcloud
  • xgboost

Packages with test failures

  • bcrypt
  • fiona

@hoodmane
Copy link
Member Author

@ryanking13 when you get a chance I'd appreciate it if you could look into why the github actions build-core fails here.

hoodmane added a commit to hoodmane/pyodide that referenced this pull request Feb 1, 2024
Generate sysconfig data as a separate .PHONY build step (it's fast and useful
to be able to retrigger so why not). Update sysconfigdata to give better values
at build time
hoodmane added a commit to hoodmane/pyodide that referenced this pull request Feb 2, 2024
Mostly this is just package upgrades for Python 3.12 compatible versions. We
also drop the distutils and nose requirements from every package. Any python
3.12 compatible package won't require them anyways so these are outdated.

cramjam required an unfortunate pywasmcross hack. I think it's a workaround for
a clang bug
hoodmane added a commit to hoodmane/pyodide that referenced this pull request Feb 2, 2024
Mostly making tests version neutral. I also deleted a few mentions of distutils
from tests and documentation.
@hoodmane hoodmane marked this pull request as ready for review February 2, 2024 00:40
hoodmane added a commit to hoodmane/pyodide that referenced this pull request Feb 2, 2024
Split off from pyodide#4468 / pyodide#4435 for visibility because it's a bit troublesome.
@hoodmane hoodmane mentioned this pull request Feb 2, 2024
1 task
ryanking13 pushed a commit that referenced this pull request Feb 3, 2024
ryanking13 pushed a commit that referenced this pull request Feb 3, 2024
hoodmane added a commit that referenced this pull request Feb 3, 2024
Split off from #4468 / #4435 for visibility because it's a bit troublesome.

clang gives a weird error saying that qsort and memcmp were not declared.
This despite the fact that the file in question imported stdlib.h where they
are declared.
Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks for your work. I have some minor comments, otherwise LGTM.

-lwebsocket.js \
-leventloop.js \
-lhiwire \
-lHacl_Hash_SHA2 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can update Setup.local such as:

_sha2 sha2module.c -I_hacl/include Modules/_hacl/libHacl_Hash_SHA2.a

instead of linking it here manually?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this in a followup PR with a bit more cpython/Makefile tidying.

@hoodmane hoodmane merged commit fb31fff into pyodide:main Feb 4, 2024
@hoodmane hoodmane deleted the python-3.12.1 branch February 4, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.12 version

3 participants