Merged
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Member
Author
|
@ryanking13 when you get a chance I'd appreciate it if you could look into why the github actions build-core fails here. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 1, 2024
Generate sysconfig data as a separate .PHONY build step (it's fast and useful to be able to retrigger so why not). Update sysconfigdata to give better values at build time
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 2, 2024
Mostly this is just package upgrades for Python 3.12 compatible versions. We also drop the distutils and nose requirements from every package. Any python 3.12 compatible package won't require them anyways so these are outdated. cramjam required an unfortunate pywasmcross hack. I think it's a workaround for a clang bug
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 2, 2024
Mostly making tests version neutral. I also deleted a few mentions of distutils from tests and documentation.
ryanking13
pushed a commit
that referenced
this pull request
Feb 2, 2024
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 2, 2024
Split off from pyodide#4468 / pyodide#4435 for visibility because it's a bit troublesome.
ryanking13
pushed a commit
that referenced
this pull request
Feb 3, 2024
ryanking13
pushed a commit
that referenced
this pull request
Feb 3, 2024
hoodmane
added a commit
that referenced
this pull request
Feb 3, 2024
ryanking13
approved these changes
Feb 3, 2024
Member
ryanking13
left a comment
There was a problem hiding this comment.
Very nice! Thanks for your work. I have some minor comments, otherwise LGTM.
| -lwebsocket.js \ | ||
| -leventloop.js \ | ||
| -lhiwire \ | ||
| -lHacl_Hash_SHA2 \ |
Member
There was a problem hiding this comment.
Maybe we can update Setup.local such as:
_sha2 sha2module.c -I_hacl/include Modules/_hacl/libHacl_Hash_SHA2.a
instead of linking it here manually?
Member
Author
There was a problem hiding this comment.
I'll fix this in a followup PR with a bit more cpython/Makefile tidying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4420.
Packages with build failures
Packages with test failures