fix: Prevent ReferenceError for id in workerApi.js example.#5307
Merged
ryanking13 merged 1 commit intopyodide:mainfrom Jan 11, 2025
Merged
fix: Prevent ReferenceError for id in workerApi.js example.#5307ryanking13 merged 1 commit intopyodide:mainfrom
ryanking13 merged 1 commit intopyodide:mainfrom
Conversation
Member
|
Thanks again! |
hoodmane
pushed a commit
that referenced
this pull request
Jan 13, 2025
Co-authored-by: David Fritz <dfritz@purestorage.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Example code for workerApi current fails due to local variable referencing. This is what happens right now if using the examples as-is:
It appears to have been because it is trying to use "id" from:
Instead of using the id outside the closure. If the id variable outside is changed (or inside), then it works. I chose to update the one outside to hopefully make it clearer. With this change, no more crash using the example.
I did not notice any open PRs or Issues for this, apologies if I overlooked anything.
Checklists