Skip to content

Update scikit-learn to 1.6.1#5342

Merged
hoodmane merged 3 commits intopyodide:mainfrom
lesteve:scikit-learn-1.6.1
Jan 19, 2025
Merged

Update scikit-learn to 1.6.1#5342
hoodmane merged 3 commits intopyodide:mainfrom
lesteve:scikit-learn-1.6.1

Conversation

@lesteve
Copy link
Contributor

@lesteve lesteve commented Jan 16, 2025

Description

Update scikit-learn to 1.6.1 released in January 2025.

Checklists

  • Add a CHANGELOG entry
  • Add / update tests
  • Add new / update outdated documentation

@ryanking13
Copy link
Member

Thanks! Could you open the PR in pyodide/pyodide-recipes too? We are planning to remove recipes from this repository to decouple the recipes and Pyodide core.

@lesteve
Copy link
Contributor Author

lesteve commented Jan 16, 2025

Good to know, done in pyodide/pyodide-recipes#65

@lesteve
Copy link
Contributor Author

lesteve commented Jan 16, 2025

The CI failures do not seem related to my PR:

  • FAILED tools/tests/test_deploy_s3.py::deploy_to_s3_mime_type - AssertionError: assert 'gzip,aws-chunked' == 'gzip' in GHA test-python build log
  • ERROR: rustup toolchain install failed in CircleCI no-numpy-dependents build log
  • test_webworker.py::runwebworker_missing_import[classic-chrome] failure in test-core-chrome-webworker build log

@hoodmane
Copy link
Member

hoodmane commented Jan 16, 2025

FAILED tools/tests/test_deploy_s3.py::deploy_to_s3_mime_type - AssertionError: assert 'gzip,aws-chunked' == 'gzip' in GHA test-python build log

Caused by the boto3 release yesterday, you can ignore it.

ERROR: rustup toolchain install failed in CircleCI no-numpy-dependents build log

Resolved on the main branch by #5348 just now, please merge main.

test_webworker.py::runwebworker_missing_import[classic-chrome]

Long standing flake, it won't block merging.

@hoodmane
Copy link
Member

Thanks @lesteve!

@hoodmane hoodmane merged commit 77a46eb into pyodide:main Jan 19, 2025
37 of 40 checks passed
@lesteve lesteve deleted the scikit-learn-1.6.1 branch January 20, 2025 13:44
@hoodmane hoodmane added this to the 0.27.2 milestone Jan 23, 2025
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants