refactor: change selenium_standalone to selenium_standalone_refresh#5902
Open
rbm0524 wants to merge 3 commits intopyodide:mainfrom
Open
refactor: change selenium_standalone to selenium_standalone_refresh#5902rbm0524 wants to merge 3 commits intopyodide:mainfrom
rbm0524 wants to merge 3 commits intopyodide:mainfrom
Conversation
ryanking13
reviewed
Sep 20, 2025
| Calling load_package with a relative URL should load the package relative to the base URL of the page. | ||
| """ | ||
| selenium = selenium_standalone_noload | ||
| def test_load_relative_url( |
Member
There was a problem hiding this comment.
Let's not introduce any changes that are not related to replacing selenium_standalone to selenium_standalone_refresh. It makes it difficult for the reviewer to review, and makes each commit less organized.
ryanking13
reviewed
Sep 20, 2025
Member
ryanking13
left a comment
There was a problem hiding this comment.
Thanks for working on this @rbm0524.
The most impactful test case that can benefit from this change in test_import, which is in
It tests all the 300+ packages in Pyodide distribution, and it take more than 20 minutes in chrome (link)
So how about testing this fixture is working in that test case first, to see how much it is effetive, then apply in other test cases after we measure the impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #5772
I changed the scope of selenium_standalone to module at fixture.py in pytest-pyodide and modified it to allow selenium_standalone_refresh to receive selenium_standalone.
In pyodide/pyodide, the test code was modified to use selenium_standalone_refresh, a refreshed selenium.
I hope this change will help you speed up the test.
Checklist