Open
Conversation
This was referenced Nov 3, 2025
ryanking13
reviewed
Nov 4, 2025
Member
ryanking13
left a comment
There was a problem hiding this comment.
Thanks! It looks good to me overall. I left some minor comments
- allow unicode - accept r-search even when there is not history - make new function applyReverseSearchSelection
Contributor
Author
|
Thanks for your review, @ryanking13. I have just reflected your comment. |
hoodmane
reviewed
Nov 4, 2025
Comment on lines
188
to
+195
| const history = []; | ||
| let historyIndex = null; // null means not navigating history | ||
|
|
||
| // Reverse search state | ||
| let reverseSearchMode = false; | ||
| let reverseSearchQuery = ""; | ||
| let reverseSearchIndex = -1; // index in history | ||
| let savedBuffer = ""; // buffer before entering search mode |
Member
There was a problem hiding this comment.
How about extracting the history state, the history loading logic, searching etc into a class?
Contributor
Author
Member
There was a problem hiding this comment.
I think we can merge this first as this is already reviewed.
ryanking13
reviewed
Nov 8, 2025
Comment on lines
+296
to
+297
| reverseSearchQuery += char; | ||
| reverseSearchIndex = searchHistory(reverseSearchQuery); |
Member
There was a problem hiding this comment.
The original console does not add a character if there is no matching history. But this will always add the charactor to the query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
reverse-searchin console-v2. (resolves #5961)It supports:
Ctrl+R: Enter the reverse-search, and find next oneCtrl+C,Ctrl+G: Cancel the reverse-searchArrows(Up, Down, Left, Right),TAB: Cancel the reverse-search with statement now focusing.