Skip to content

MNT Update to firefox 70.0 / geckodriver 0.26 in CI#622

Merged
rth merged 9 commits intopyodide:masterfrom
rth:update-gecko-chrome-drivers
Jul 8, 2020
Merged

MNT Update to firefox 70.0 / geckodriver 0.26 in CI#622
rth merged 9 commits intopyodide:masterfrom
rth:update-gecko-chrome-drivers

Conversation

@rth
Copy link
Member

@rth rth commented Mar 12, 2020 •
edited
Loading

geckodriver and chromedriver used in CI were released around 2018-2019. This updates them to latest versions. Hoping that this could make Chrome testing a bit more reliable.

@rth
Copy link
Member Author

rth commented Mar 12, 2020

The current error is

Error: Cannot find module 'commander'
    at Function.Module._resolveFilename (module.js:536:15)
    at Function.Module._load (module.js:466:25)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/usr/share/nodejs/uglify-js/bin/uglifyjs:11:15)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
Makefile:91: recipe for target 'build/pyodide.asm.data' failed
make: *** [build/pyodide.asm.data] Error 1

and installing node-commander manually doens't help. Some issue with nodejs dependencies. Will try to investigate later..

@rth rth changed the title Update geckodriver and chromedriver WIP Update geckodriver and chromedriver Mar 12, 2020
@rth rth mentioned this pull request Jun 2, 2020
Merged
@rth rth marked this pull request as draft July 4, 2020 19:26
@rth
Copy link
Member Author

rth commented Jul 5, 2020

So far several tests with latest chrome fail with TimeoutError, while some tests in the CPython tests suite fail with latest firefox with a maximum recursion depth reached error. This would require more investigation.

@rth rth mentioned this pull request Jul 5, 2020
Merged
5 tasks
@rth rth marked this pull request as ready for review July 8, 2020 20:45
@rth rth changed the title WIP Update geckodriver and chromedriver MNT Update to firefox 70.0 / geckodriver 0.26 in CI Jul 8, 2020
@rth rth mentioned this pull request Jul 8, 2020
Closed
@rth rth merged commit 018f4a2 into pyodide:master Jul 8, 2020
@rth rth deleted the update-gecko-chrome-drivers branch July 8, 2020 22:37
@rth rth added this to the 0.16.0 milestone Aug 16, 2020
@sylvain-ri
Copy link
Contributor

sylvain-ri commented Sep 21, 2021

Fixed by following advice on stack overflow :
"You installed uglify globally, it won't be "visible" to your package. You want to run npm install uglify-js (without the -g) inside the directory/package where your script is located."

#1852 would be a better solution as suggested by @rth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.16.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rth @sylvain-ri