Skip to content

gh-61448: Fix inspect.getargvalues fails if arg name is not bound to a value #101318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
furkanonder wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-61448: Fix inspect.getargvalues fails if arg name is not bound to a value #101318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
75b3fe6
Fix inspect.getargvalues fails if arg name is not bound to a value
furkanonder Jan 25, 2023
5e6cb02
Merge branch 'main' into issue-61448
furkanonder Jan 25, 2023
06601e1
Merge branch 'main' into issue-61448
furkanonder Jan 25, 2023
6c59a29
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 26, 2023
0afa69a
Add testcases for function arguments
furkanonder Mar 30, 2023
35a9cec
Add testcase for formatargvalues function
furkanonder Mar 30, 2023
dd8a14a
Mention the co-author
furkanonder Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Lib/inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1462,6 +1462,14 @@ def _formatannotation(annotation):
return formatannotation(annotation, module)
return _formatannotation

# A placeholder with <deleted> as repr (using a string would have '<deleted>'
# with quotes). This is used in formatargvalues function.
class _Deleted:
def __repr__(self):
return '<deleted>'

_deleted = _Deleted()
del _Deleted

def formatargvalues(args, varargs, varkw, locals,
formatarg=str,
Expand All @@ -1476,7 +1484,7 @@ def formatargvalues(args, varargs, varkw, locals,
argument is an optional function to format the sequence of arguments."""
def convert(name, locals=locals,
formatarg=formatarg, formatvalue=formatvalue):
return formatarg(name) + formatvalue(locals[name])
return formatarg(name) + formatvalue(locals.get(name, _deleted))
specs = []
for i in range(len(args)):
specs.append(convert(args[i]))
Expand Down
15 changes: 15 additions & 0 deletions Lib/test/test_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,21 @@ def test_frame(self):
self.assertEqual(inspect.formatargvalues(args, varargs, varkw, locals),
'(x=11, y=14)')

def return_current_frame(x):
return inspect.currentframe()

self.assertEqual(inspect.formatargvalues(*inspect.getargvalues(return_current_frame(5))), "(x=5)")
self.assertEqual(inspect.formatargvalues(*inspect.getargvalues(return_current_frame(9))), "(x=9)")

# See issue-61448
def test_formatargvalues_deleted_args(self):
def fun(a, b, x, y):
del b, y
return inspect.currentframe()

args = inspect.getargvalues(fun(2, 4, 8, 16))
self.assertEqual(inspect.formatargvalues(*args), '(a=2, b=<deleted>, x=8, y=<deleted>)')

def test_previous_frame(self):
args, varargs, varkw, locals = inspect.getargvalues(mod.fr.f_back)
self.assertEqual(args, ['a', 'b', 'c', 'd', 'e', 'f'])
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2023-01-26-09-36-24.gh-issue-61448.SOAkvt.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix inspect.getargvalues function failing if arg name is not bound to a value.
Co-authored-by Ezio Melotti.