gh-102519: Add os.listdrives, os.listvolumes and os.listmounts on Windows#102544
Merged
zooba merged 6 commits intopython:mainfrom Mar 10, 2023
Merged
gh-102519: Add os.listdrives, os.listvolumes and os.listmounts on Windows#102544zooba merged 6 commits intopython:mainfrom
zooba merged 6 commits intopython:mainfrom
Conversation
eryksun
reviewed
Mar 9, 2023
eryksun
reviewed
Mar 9, 2023
eryksun
reviewed
Mar 10, 2023
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Member
Author
|
I'm going to go ahead and assume that if all you've found is whitespace, there are no problems left to find 😉 Thanks for the review, as always. Really appreciate having you check this stuff out |
Contributor
I thought you weren't finished yet since the PR doesn't document the new functions in "Doc/library/os.rst". |
Member
Author
|
Weird, I definitely wrote those docs... I wonder where they've gone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.listdriveson Windows #102519