Skip to content

gh-105745: Fix open method of webbrowser.Konqueror#105746

Merged
vstinner merged 2 commits intopython:mainfrom
sobolevn:issue-105745
Jun 14, 2023
Merged

gh-105745: Fix open method of webbrowser.Konqueror#105746
vstinner merged 2 commits intopython:mainfrom
sobolevn:issue-105745

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Jun 13, 2023 •
edited by bedevere-bot
Loading

@sobolevn sobolevn requested a review from vstinner June 13, 2023 20:22
@bedevere-bot bedevere-bot mentioned this pull request Jun 13, 2023
Closed
@merwok merwok changed the title gh-105745: Fix two open methods on webbrowsers.Konqueror gh-105745: Fix open method of webbrowser.Konqueror Jun 13, 2023
vstinner
vstinner approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DBJim
Copy link
Contributor

DBJim commented Jun 13, 2023

Good spot!

@vstinner vstinner merged commit e5d45b7 into python:main Jun 14, 2023
@vstinner
Copy link
Member

vstinner commented Jun 14, 2023

Merged, thanks for the quick fix.

@DBJim
Copy link
Contributor

DBJim commented Jun 14, 2023

Thank you both! Can we backport the fix to 3.12?

@vstinner vstinner added the needs backport to 3.12 only security fixes label Jun 14, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jun 14, 2023

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2023
@sobolevn @miss-islington
pythongh-105745: Fix open method of webbrowser.Konqueror (pythonGH-10…
146673a 
…5746)

(cherry picked from commit e5d45b7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

bedevere-bot commented Jun 14, 2023

GH-105777 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 14, 2023
vstinner pushed a commit that referenced this pull request Jun 14, 2023
@miss-islington @sobolevn
[3.12] gh-105745: Fix open method of webbrowser.Konqueror (GH-105746) (…
ad7371e 
…#105777)

gh-105745: Fix open method of webbrowser.Konqueror (GH-105746)
(cherry picked from commit e5d45b7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @DBJim @vstinner @miss-islington @bedevere-bot

Comments