Skip to content

gh-108111: Flush gzip write buffer before seeking, fixing bad writes #108341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 5 commits into from
Aug 24, 2023
Merged

gh-108111: Flush gzip write buffer before seeking, fixing bad writes #108341

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa32f84
Add test demonstrating GH-108111
effigies Aug 22, 2023
df0c5bf
Flush gzip write buffer before seeking; fixes GH-10811
effigies Aug 22, 2023
1a1130b
Write NEWS blurb
effigies Aug 22, 2023
3d39458
Add self to ACKS
effigies Aug 22, 2023
c123209
Merge branch 'main' into fix/gzip-writeseekwrite
ambv Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test demonstrating GH-108111
  • Loading branch information
@effigies
effigies committed Aug 22, 2023
commit aa32f84095e91d8ffeaf9b3a17ba6e0ef9f80c0b
12 changes: 12 additions & 0 deletions Lib/test/test_gzip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,18 @@ def flush(self, mode=-1):
]
self.assertEqual(fc.modes, expected_modes)

def test_write_seek_write(self):
# Make sure that offset is up-to-date before seeking
# See issue GH-108111
b = io.BytesIO()
message = b"important message here."
with gzip.GzipFile(fileobj=b, mode='w') as f:
f.write(message)
f.seek(len(message))
f.write(message)
data = b.getvalue()
self.assertEqual(gzip.decompress(data), message * 2)


class TestOpen(BaseTest):
def test_binary_modes(self):
Expand Down