gh-119577: Adjust DeprecationWarning when testing element truth values in ElementTree#119762
Merged
gpshead merged 3 commits intopython:mainfrom Jun 7, 2024
Merged
Conversation
… values in ElementTree
|
Thanks @jacobtylerwalls for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2024
… values in ElementTree (pythonGH-119762) Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases. (cherry picked from commit 6b60652) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
|
GH-120189 is a backport of this pull request to the 3.13 branch. |
gpshead
pushed a commit
to gpshead/cpython
that referenced
this pull request
Jun 7, 2024
… values in ElementTree (pythonGH-119762) Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases.
|
GH-120190 is a backport of this pull request to the 3.12 branch. |
gpshead
pushed a commit
that referenced
this pull request
Jun 7, 2024
…h values in ElementTree (GH-119762) (GH-120189) gh-119577: Adjust DeprecationWarning when testing element truth values in ElementTree (GH-119762) Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases. (cherry picked from commit 6b60652) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
pygeek
pushed a commit
to pygeek/cpython
that referenced
this pull request
Jun 7, 2024
… values in ElementTree (pythonGH-119762) Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
… values in ElementTree (pythonGH-119762) Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
… values in ElementTree (pythonGH-119762) Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases.
Yhg1s
pushed a commit
that referenced
this pull request
Aug 6, 2024
…h values in Element tree (GH-119762) (#120190) gh-119577: Adjust DeprecationWarning when testing element truth values in ElementTree (GH-119762) Adjust DeprecationWarning when testing element truth values in ElementTree, we're planning to go with the more natural True return rather than a disruptive harder to code around exception raise, and are deferring the behavior change for a few more releases. Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust this deprecation warning to refer to returning True regardless of the existence of subelements (rather than raising an exception in 3.14).
I'm not sure whether this should be described as pending for 3.16 or just "future versions".
xml.etree.ElementTree.Element#119577📚 Documentation preview 📚: https://cpython-previews--119762.org.readthedocs.build/