GH-120754: Add a strace helper and test set of syscalls for open().read()#121143
Merged
hauntsaninja merged 23 commits intopython:mainfrom Aug 24, 2024
Merged
GH-120754: Add a strace helper and test set of syscalls for open().read()#121143hauntsaninja merged 23 commits intopython:mainfrom
hauntsaninja merged 23 commits intopython:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General goal here is to be able to add tests that behavior isn't unintentionally changed around some common python code patterns, in particular Path("README.rst").read_text().
This started with the code that validated
subprocessused vfork, building more general utilities from that core code. The work was motivated in #120755 for how to test that particular change.TODO
Figure out why the-- This is the documented behavior of stdout https://docs.python.org/3/library/sys.html#sys.stdout. Because they're files / not interactive it gets block buffered meaning only once a buffer is full does it flush rather than write() when a print() happens.print()of markers needs flush=True to not buffer them. Likely add a test for two print statements not being merged using this infrastructure.Validate at least once CI bot actually runs and passes the test-- Ubuntu / Build and test found that glibc there uses newfstat which caused the test to fail. Updated the test to allow libc to use other fstat variants.