gh-109413: Enable strict_optional = true for libregrtest/run_workers#126855
Merged
sobolevn merged 8 commits intopython:mainfrom Nov 18, 2024
Merged
gh-109413: Enable strict_optional = true for libregrtest/run_workers#126855sobolevn merged 8 commits intopython:mainfrom
strict_optional = true for libregrtest/run_workers#126855sobolevn merged 8 commits intopython:mainfrom
Conversation
vstinner
reviewed
Nov 15, 2024
Member
Author
|
Failure is related: Fixing |
AlexWaygood
reviewed
Nov 15, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Nov 15, 2024
vstinner
reviewed
Nov 15, 2024
vstinner
reviewed
Nov 18, 2024
| super().__init__() | ||
|
|
||
|
|
||
| _NOT_RUNNING = "<not running>" |
Member
There was a problem hiding this comment.
You can make it public, it's not a deep secret.
Member
Author
There was a problem hiding this comment.
I don't think that it needs to be public, since it is not used outside of this module and probably won't be. If you prefer to have it as public - I will change it :)
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 18, 2024
…_workers` (pythonGH-126855) (cherry picked from commit a1d9c8a) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
GH-126967 is a backport of this pull request to the 3.13 branch. |
Member
Author
|
Thanks everyone for so many helpful suggestions! It turned out very good! 👍 |
Member
|
Thanks for your nice change. |
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…_workers` (python#126855) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.