gh-100239: specialize left and right shift ops on ints#129431
Open
eendebakpt wants to merge 13 commits intopython:mainfrom
Open
gh-100239: specialize left and right shift ops on ints#129431eendebakpt wants to merge 13 commits intopython:mainfrom
eendebakpt wants to merge 13 commits intopython:mainfrom
Conversation
Member
|
@eendebakpt, something happened with the milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We add a specialization for
>>and>>on compact integers.<<can overflow, so we restrict shifts to values smaller than 17. Under this assumption the value ofa << bwithb <= 16) fit into a 32-bit or 64-bit integer depending on the platform.Benchmark:
(non-PGO, Windows)
There is a gain with the specialization, but on the other hand: how many shift operations on compact ints are there? For example the shifts are used in the
uuidmodule, but always on large ints.