gh-130327: Always traverse managed dictionaries, even when inline values are available#130469
Merged
colesbury merged 17 commits intopython:mainfrom Mar 2, 2026
Merged
Conversation
…n't inline values" This reverts commit 8a29421.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I turned this into a mess when trying to debug the other crash.
Contributor
|
I'm taking a look at this now. I think there's a second bug involving dictionaries |
Contributor
|
Oh, we already have an issue for the other bug: #130555 |
Member
Author
|
Feel free to open your own PR if that's easier. |
|
Thanks @ZeroIntensity for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 2, 2026
…ne values are available (pythonGH-130469) (cherry picked from commit 592e8f0) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
Sorry, @ZeroIntensity and @colesbury, I could not cleanly backport this to |
|
GH-145438 is a backport of this pull request to the 3.14 branch. |
colesbury
pushed a commit
to colesbury/cpython
that referenced
this pull request
Mar 2, 2026
…en inline values are available (pythonGH-130469) (cherry picked from commit 592e8f0) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
GH-145440 is a backport of this pull request to the 3.13 branch. |
Member
Author
|
Thanks for handling this :) |
colesbury
pushed a commit
that referenced
this pull request
Mar 2, 2026
colesbury
added a commit
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__dict__can get collected too early. #130327