gh-132284: Don't wrap base PyCFunction slots on class creation if not overridden#132329
Merged
iritkatriel merged 9 commits intopython:mainfrom Apr 17, 2025
Merged
gh-132284: Don't wrap base PyCFunction slots on class creation if not overridden#132329iritkatriel merged 9 commits intopython:mainfrom
iritkatriel merged 9 commits intopython:mainfrom
Conversation
Member
|
Do we have a test that something like this continues to work correctly? If not, maybe we should add one: >>> class D(dict):
... pass
...
>>> d = D({None: None})
>>> assert d[None] is None
>>> D.__getitem__ = lambda self, item: 42
>>> assert d[None] == 42 |
Member
|
This is probably worth an entry in "what's new" in case someone notices something change for some edge case. |
Member
|
Also note merge conflict. |
Contributor
Author
Have a look at addition to whatsnew. Not sure if is right place so if you want something else then tell me what to put where or feel free to change as needed. |
iritkatriel
reviewed
Apr 15, 2025
iritkatriel
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will not wrap slot functions from base classes if they are not explicitly overridden on class creations.
Subclass
__getitem__()performance even increases a bit from:to:
Rationale for the checks is as follows:
generic == NULLbecause not sure of behavior with slots that loop several times liketp_getattr,tp_setattrandtp_richcompare.Py_IS_TYPE(descr, &PyMethodDescr_Type)because only if setting pre-existing builtin C method.*ptr == ((PyMethodDescrObject *)descr)->d_method->ml_methchecks both*ptr != NULLand stuff like: