gh-84481: Remove the executable bits from test files#132507
Closed
befeleme wants to merge 1 commit intopython:mainfrom
Closed
gh-84481: Remove the executable bits from test files#132507befeleme wants to merge 1 commit intopython:mainfrom
befeleme wants to merge 1 commit intopython:mainfrom
Conversation
They are not intended to be run directly. Some Linux distributions (e.g. Fedora) mangle shebangs of the executable files, changing the data offset calculated in test_zipfile.
Contributor
Author
|
This breaks the world, the initial assumption was incorrect, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are not intended to be run directly.
Some Linux distributions (e.g. Fedora) mangle shebangs of the executable files, changing the data offset calculated in test_zipfile.