gh-135573: Add a check for 0 items to APPENDS and ADDITEMS opcodes#135574
Closed
Legoclones wants to merge 2 commits intopython:mainfrom
Closed
gh-135573: Add a check for 0 items to APPENDS and ADDITEMS opcodes#135574Legoclones wants to merge 2 commits intopython:mainfrom
APPENDS and ADDITEMS opcodes#135574Legoclones wants to merge 2 commits intopython:mainfrom
Conversation
Member
|
This can only happen when the list is modified during pickling, in which case you may have a larger issue. The additional check has a cost which will never pay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align the C and Python implementations of pickle, a check for 0 items is added to the
picklemodule forAPPENDSandADDITEMSopcodes.APPENDSandADDITEMSmissing check #135573