gh-135532: simplify handling of HACL* errors in _hmac#135740
gh-135532: simplify handling of HACL* errors in _hmac#135740picnixz merged 1 commit intopython:mainfrom
_hmac#135740Conversation
|
!buildbot FIPS only |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit b7a132f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135740%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…GH-135740) (cherry picked from commit 2dbada1) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-135743 is a backport of this pull request to the 3.14 branch. |
|
When I first wrote this module, I wanted to be as pedantic as possible. However, the code became overly complex and having a better traceback when getting
Hacl_Streaming_Types_InvalidAlgorithmis not really interesting because it should, in practice, never happen.Hacl_Streaming_Types_InvalidAlgorithmis only returned when we allocate HMAC with BLAKE-2 but... that shouldn't be possible because we're not supporting HMAC-BLAKE (BLAKE is already playing the role of a keyed hash function).