gh-136170: Use earliest zinfo.header_offset as ZipFile.data_offset#136171
Closed
danifus wants to merge 1 commit intopython:mainfrom
Closed
gh-136170: Use earliest zinfo.header_offset as ZipFile.data_offset#136171danifus wants to merge 1 commit intopython:mainfrom
danifus wants to merge 1 commit intopython:mainfrom
Conversation
Contributor
Author
|
#84481 was reopened and the addition of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the earliest
zinfo.header_offsetforZipFile.data_offset.We already sort the
zinfos by theirheader_offsetin_RealGetContentsso it is cheap to grab the zinfo with the lowestheader_offset.Happy to add a news entry if required (given that 3.14 which introduced
ZipFile.data_offsethasn't been released yet?)