gh-136170: Revert adding `ZipFile.data_offset` by emmatyping · Pull Request #136950 · python/cpython

emmatyping · 2025-07-21T19:45:15Z

As reported in #136170, ZipFile.data_offset isn't always correct depending on how one measures offsets. With 3.14rc1 tomorrow, I decided it would be best to push this to 3.15 and take more time to think about the feature and it's implementation.

This PR reverts PRs #132165 and #132178.

Note that I had to resolve a merge conflict in ZipFile._RealGetContents due to #134250 landing after the two PRs adding data_offset, so this isn't quite a clean revert of the two above PRs.

Issue: Alter ZipFile.data_offset calculation #136170

📚 Documentation preview 📚: https://cpython-previews--136950.org.readthedocs.build/

…132178)" This reverts commit 6cd1d6c.

)" This reverts commit 0788948.

gpshead

I added a news entry for completeness as someone reading the verbose news could find the earlier news entry and wonder otherwise.

Misc/NEWS.d/next/Library/2025-07-21-22-35-50.gh-issue-136170.QUlc78.rst

…Ulc78.rst

picnixz · 2025-07-21T22:50:52Z

I've updated the NEWS entry to use the exact versioning as in PEP-745.

miss-islington-app · 2025-07-21T23:16:33Z

Thanks @emmatyping for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

* Revert "pythongh-84481: Make ZipFile.data_offset more robust (pythonGH-132178)" This reverts commit 6cd1d6c. * Revert "pythongh-84481: Add ZipFile.data_offset attribute (pythonGH-132165)" This reverts commit 0788948. --------- (cherry picked from commit 6bf1c0a) Co-authored-by: Emma Smith <emma@emmatyping.dev> Co-authored-by: Gregory P. Smith <greg@krypto.org>

bedevere-app · 2025-07-21T23:16:45Z

GH-136955 is a backport of this pull request to the 3.14 branch.

emmatyping · 2025-07-22T01:27:25Z

I added a news entry for completeness as someone reading the verbose news could find the earlier news entry and wonder otherwise.

Thanks! That's a good idea.

…36955) gh-136170: Revert adding `ZipFile.data_offset` (GH-136950) * Revert "gh-84481: Make ZipFile.data_offset more robust (GH-132178)" This reverts commit 6cd1d6c. * Revert "gh-84481: Add ZipFile.data_offset attribute (GH-132165)" This reverts commit 0788948. --------- (cherry picked from commit 6bf1c0a) Co-authored-by: Emma Smith <emma@emmatyping.dev> Co-authored-by: Gregory P. Smith <greg@krypto.org>

bedevere-bot · 2025-07-22T04:59:06Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian Linux Asan 3.14 (no tier) has failed when building commit caef946.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1816/builds/25) and take a look at the build logs.
Check if the failure is related to this commit (caef946) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1816/builds/25

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 16, done.        
remote: Counting objects:   8% (1/12)        
remote: Counting objects:  16% (2/12)        
remote: Counting objects:  25% (3/12)        
remote: Counting objects:  33% (4/12)        
remote: Counting objects:  41% (5/12)        
remote: Counting objects:  50% (6/12)        
remote: Counting objects:  58% (7/12)        
remote: Counting objects:  66% (8/12)        
remote: Counting objects:  75% (9/12)        
remote: Counting objects:  83% (10/12)        
remote: Counting objects:  91% (11/12)        
remote: Counting objects: 100% (12/12)        
remote: Counting objects: 100% (12/12), done.        
remote: Compressing objects:   8% (1/12)        
remote: Compressing objects:  16% (2/12)        
remote: Compressing objects:  25% (3/12)        
remote: Compressing objects:  33% (4/12)        
remote: Compressing objects:  41% (5/12)        
remote: Compressing objects:  50% (6/12)        
remote: Compressing objects:  58% (7/12)        
remote: Compressing objects:  66% (8/12)        
remote: Compressing objects:  75% (9/12)        
remote: Compressing objects:  83% (10/12)        
remote: Compressing objects:  91% (11/12)        
remote: Compressing objects: 100% (12/12)        
remote: Compressing objects: 100% (12/12), done.        
remote: Total 16 (delta 0), reused 0 (delta 0), pack-reused 4 (from 1)        
From https://github.com/python/cpython
 * branch                    3.14       -> FETCH_HEAD
Note: switching to 'caef946a25aac557f13cb66fbc70f06225546e67'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at caef946a25a [3.14] gh-136170: Revert adding `ZipFile.data_offset` (GH-136950) (#136955)
Switched to and reset branch '3.14'

configure: WARNING: no system libmpdec found; falling back to bundled libmpdec (deprecated and scheduled for removal in Python 3.16)

In file included from ./Include/internal/pycore_dict.h:11,
                 from Objects/typeobject.c:7:
In function ‘Py_DECREF_MORTAL’,
    inlined from ‘PyStackRef_XCLOSE’ at ./Include/internal/pycore_stackref.h:660:9,
    inlined from ‘_PyThreadState_PopCStackRef’ at ./Include/internal/pycore_stackref.h:746:5,
    inlined from ‘vectorcall_maybe’ at Objects/typeobject.c:2980:9:
./Include/internal/pycore_object.h:481:8: warning: array subscript 0 is outside array bounds of ‘PyObject[0]’ {aka ‘struct _object[]’} [-Warray-bounds]
  481 |     if (--op->ob_refcnt == 0) {
      |        ^

Timeout (0:05:00)!
Thread 0x0000007f9b0ef100 [Thread-2] (most recent call first):
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2058 in _wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 1278 in wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 194 in _run_process
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 299 in run_tmp_files
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 363 in _runtest
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 403 in run
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1081 in _bootstrap_inner
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1043 in _bootstrap

Thread 0x0000007f9b8ff100 [Thread-1] (most recent call first):
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2022 in _try_wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2047 in _wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 1278 in wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 194 in _run_process
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 299 in run_tmp_files
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 363 in _runtest
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 403 in run
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1081 in _bootstrap_inner
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1043 in _bootstrap

Thread 0x0000007fa767c6c0 [python] (most recent call first):
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/utils.py", line 61 in format_duration
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 464 in get_running
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 551 in _get_result
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 610 in run
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 455 in _run_tests_mp
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 561 in _run_tests
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 598 in run_tests
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 767 in main
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 775 in main
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/__main__.py", line 2 in <module>
  File "<frozen runpy>", line 88 in _run_code
  File "<frozen runpy>", line 198 in _run_module_as_main
make: *** [Makefile:2462: buildbottest] Error 1

Cannot open file '/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/test-results.xml' for upload

- The `data_offset` attribute is retracted in 3.14rc: ref: python/cpython#136950

* Revert "pythongh-84481: Make ZipFile.data_offset more robust (python#132178)" This reverts commit 6cd1d6c. * Revert "pythongh-84481: Add ZipFile.data_offset attribute (python#132165)" This reverts commit 0788948. --------- Co-authored-by: Gregory P. Smith <greg@krypto.org>

…-136950) (python#136955) pythongh-136170: Revert adding `ZipFile.data_offset` (pythonGH-136950) * Revert "pythongh-84481: Make ZipFile.data_offset more robust (pythonGH-132178)" This reverts commit 6cd1d6c. * Revert "pythongh-84481: Add ZipFile.data_offset attribute (pythonGH-132165)" This reverts commit 0788948. --------- (cherry picked from commit 6bf1c0a) Co-authored-by: Emma Smith <emma@emmatyping.dev> Co-authored-by: Gregory P. Smith <greg@krypto.org>

emmatyping added 2 commits July 20, 2025 18:54

Revert "pythongh-84481: Make ZipFile.data_offset more robust (python#…

8eb63c9

…132178)" This reverts commit 6cd1d6c.

Revert "pythongh-84481: Add ZipFile.data_offset attribute (python#132165

4221022

)" This reverts commit 0788948.

emmatyping requested a review from gpshead July 21, 2025 19:45

emmatyping added skip news needs backport to 3.14 bugs and security fixes labels Jul 21, 2025

bedevere-app bot added the awaiting review label Jul 21, 2025

emmatyping changed the title ~~gh-136170: Revert ZipFile.data_offset~~ gh-136170: Revert adding ZipFile.data_offset Jul 21, 2025

bedevere-app bot mentioned this pull request Jul 21, 2025

Alter ZipFile.data_offset calculation #136170

Closed

NEWS entry about the removal.

c341057

gpshead removed the skip news label Jul 21, 2025

reword news

8309110

gpshead approved these changes Jul 21, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Jul 21, 2025

gpshead enabled auto-merge (squash) July 21, 2025 22:39

picnixz reviewed Jul 21, 2025

View reviewed changes

Misc/NEWS.d/next/Library/2025-07-21-22-35-50.gh-issue-136170.QUlc78.rst Outdated Show resolved Hide resolved

Update Misc/NEWS.d/next/Library/2025-07-21-22-35-50.gh-issue-136170.Q…

289b7cd

…Ulc78.rst

picnixz approved these changes Jul 21, 2025

View reviewed changes

gpshead merged commit 6bf1c0a into python:main Jul 21, 2025
41 checks passed

bedevere-app bot removed the awaiting merge label Jul 21, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 21, 2025

danny0838 added a commit to danny0838/zipremove that referenced this pull request Jul 22, 2025

Remove data_offset updating

fba2fca

- The `data_offset` attribute is retracted in 3.14rc: ref: python/cpython#136950

danny0838 mentioned this pull request Jul 22, 2025

gh-51067: Add remove() and repack() to ZipFile #134627

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-136170: Revert adding `ZipFile.data_offset`#136950

gh-136170: Revert adding `ZipFile.data_offset`#136950
gpshead merged 5 commits intopython:mainfrom
emmatyping:revert-zipfile-data-offset

emmatyping commented Jul 21, 2025 •

edited by github-actions bot

Loading

Uh oh!

gpshead left a comment

Uh oh!

Uh oh!

picnixz commented Jul 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

miss-islington-app bot commented Jul 21, 2025

Uh oh!

bedevere-app bot commented Jul 21, 2025

Uh oh!

emmatyping commented Jul 22, 2025

Uh oh!

bedevere-bot commented Jul 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

emmatyping commented Jul 21, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpshead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

picnixz commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

miss-islington-app bot commented Jul 21, 2025

Uh oh!

bedevere-app bot commented Jul 21, 2025

Uh oh!

emmatyping commented Jul 22, 2025

Uh oh!

bedevere-bot commented Jul 22, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

emmatyping commented Jul 21, 2025 •

edited by github-actions bot

Loading

picnixz commented Jul 21, 2025 •

edited

Loading