gh-76007: Deprecate `__version__` attribute by hugovk · Pull Request #138675 · python/cpython

hugovk · 2025-09-08T16:33:01Z

Issue: Misleading __version__ attribute of modules in standard library #76007

📚 Documentation preview 📚: https://cpython-previews--138675.org.readthedocs.build/

sethmlarson · 2025-09-08T16:39:42Z

Reviewed the SBOM changes.

merwok · 2025-09-09T01:26:33Z

Doc/whatsnew/3.15.rst


+.. include:: ../deprecations/pending-removal-in-3.16.rst
+
+.. include:: ../deprecations/pending-removal-in-3.17.rst


So this will show the same list twice in this page?

Yep, that's how we're already doing it for other ones (I'm not sure if we should, but that's another discussion).

merwok

thanks for this!

vsajip

I'm fine with the logging-related changes, thank you.

Lib/ctypes/macholib/__init__.py

Lib/test/test_socketserver.py

Co-authored-by: AN Long <aisk@users.noreply.github.com>

savannahostrowski

LGTM for argparse! Thanks Hugo!

Co-authored-by: Petr Viktorin <encukou@gmail.com>

Doc/deprecations/pending-removal-in-3.17.rst

Lib/test/test_argparse.py

Lib/test/test_csv.py

Lib/test/test_re.py

Lib/test/test_socketserver.py

Lib/test/test_tabnanny.py

Lib/test/test_tkinter/test_font.py

Lib/test/test_ttk/__init__.py

vstinner

LGTM

bedevere-bot · 2025-09-29T10:04:41Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows PGO NoGIL 3.x (tier-1) has failed when building commit 872eafd.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1622/builds/2753) and take a look at the build logs.
Check if the failure is related to this commit (872eafd) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1622/builds/2753

Failed tests:

test_tracemalloc
test_zipfile

Failed subtests:

test_write_filtered_python_package - test.test_zipfile.test_core.PyZipFileTests.test_write_filtered_python_package

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\test\test_zipfile\test_core.py", line 1435, in test_write_filtered_python_package
    zipfp.writepy(packagedir)
    ~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\zipfile\__init__.py", line 2226, in writepy
    self.writepy(path, basename,
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^
                 filterfunc=filterfunc)  # Recursive call
                 ^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\zipfile\__init__.py", line 2233, in writepy
    fname, arcname = self._get_codename(path[0:-3],
                     ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
                                        basename)
                                        ^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\zipfile\__init__.py", line 2313, in _get_codename
    if _compile(file_py):
       ~~~~~~~~^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\zipfile\__init__.py", line 2276, in _compile
    py_compile.compile(file, doraise=True, optimize=optimize)
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\py_compile.py", line 172, in compile
    importlib._bootstrap_external._write_atomic(cfile, bytecode, mode)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap_external>", line 217, in _write_atomic
PermissionError: [WinError 5] Access is denied: 'C:\\Users\\Administrator\\buildarea\\3.x.itamaro-win64-srv-22-aws.nogil.pgo\\build\\Lib\\test\\test_ast\\__pycache__\\snippets.cpython-315.pyc.3206632993856' -> 'C:\\Users\\Administrator\\buildarea\\3.x.itamaro-win64-srv-22-aws.nogil.pgo\\build\\Lib\\test\\test_ast\\__pycache__\\snippets.cpython-315.pyc'

bedevere-bot · 2025-09-29T12:19:01Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows PGO NoGIL 3.x (tier-1) has failed when building commit 872eafd.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1622/builds/2755) and take a look at the build logs.
Check if the failure is related to this commit (872eafd) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1622/builds/2755

Failed tests:

test_launcher

Failed subtests:

test_search_major_2 - test.test_launcher.TestLauncher.test_search_major_2
test_search_major_3 - test.test_launcher.TestLauncher.test_search_major_3

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\test\test_launcher.py", line 445, in test_search_major_3
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\test\test_launcher.py", line 465, in test_search_major_2
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite

hugovk · 2025-09-29T12:28:12Z

Buildbot failure unrelated: likely a problem with the buildbot state requiring a restart.

hugovk added 2 commits September 8, 2025 17:38

Deprecate __version__ attribute

38e19bd

Update SBOM checksums for Lib/ctypes/macholib/__init__.py

c23ee78

hugovk requested review from AA-Turner, savannahostrowski, sethmlarson and vsajip as code owners September 8, 2025 16:33

bedevere-app bot added the awaiting core review label Sep 8, 2025

bedevere-app bot mentioned this pull request Sep 8, 2025

Misleading __version__ attribute of modules in standard library #76007

Closed

sethmlarson approved these changes Sep 8, 2025

View reviewed changes

merwok reviewed Sep 9, 2025

View reviewed changes

merwok approved these changes Sep 9, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels Sep 9, 2025

vsajip approved these changes Sep 9, 2025

View reviewed changes

encukou reviewed Sep 9, 2025

View reviewed changes

Lib/ctypes/macholib/__init__.py Outdated Show resolved Hide resolved

aisk reviewed Sep 10, 2025

View reviewed changes

Lib/test/test_socketserver.py Show resolved Hide resolved

Whitespace

6e01534

Co-authored-by: AN Long <aisk@users.noreply.github.com>

savannahostrowski approved these changes Sep 15, 2025

View reviewed changes

hugovk and others added 3 commits September 17, 2025 10:34

Merge branch 'main' into 3.15-deprecate__version__

ddb6a2b

Deprecate for recommended five years

7b13a13

Co-authored-by: Petr Viktorin <encukou@gmail.com>

Deprecate for recommended five years

bfbe4b7

hugovk commented Sep 17, 2025

View reviewed changes

hugovk added 4 commits September 17, 2025 12:49

Deprecate for recommended five years

6bb4cbe

Re-update SBOM checksums for Lib/ctypes/macholib/__init__.py

d352594

Fix Sphinx

d17235d

Fix Sphinx

134c8be

vstinner approved these changes Sep 18, 2025

View reviewed changes

hugovk merged commit 872eafd into python:main Sep 29, 2025
45 checks passed

hugovk deleted the 3.15-deprecate__version__ branch September 29, 2025 09:03

bedevere-app bot removed the awaiting merge label Sep 29, 2025

hugovk mentioned this pull request Nov 29, 2025

gh-129294: use winapi to determine win version before invoking cmd.exe #129295

Open

hroncok mentioned this pull request Feb 18, 2026

json.__version__ is deprecated and used in tests pypa/setuptools#5186

Open


		.. include:: ../deprecations/pending-removal-in-3.16.rst

		.. include:: ../deprecations/pending-removal-in-3.17.rst

Uh oh!

Comments

Conversation

hugovk commented Sep 8, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sethmlarson commented Sep 8, 2025

Uh oh!

merwok Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

hugovk Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

merwok left a comment

Choose a reason for hiding this comment

Uh oh!

vsajip left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

savannahostrowski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Sep 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Sep 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

hugovk commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

hugovk commented Sep 8, 2025 •

edited by github-actions bot

Loading