Skip to content

Comments

gh-140438: Properly run the asyncio REPL in REPL tests#140298

Merged
kumaraditya303 merged 2 commits intopython:mainfrom
johnslavik:properly-run-asyncio-repl-in-repl-tests
Oct 23, 2025
Merged

gh-140438: Properly run the asyncio REPL in REPL tests#140298
kumaraditya303 merged 2 commits intopython:mainfrom
johnslavik:properly-run-asyncio-repl-in-repl-tests

Conversation

@johnslavik
Copy link
Member

@johnslavik johnslavik commented Oct 18, 2025 •
edited by bedevere-app bot
Loading

Mixing -i with -m asyncio first spawns the asyncio REPL. After asyncio REPL exits, it spawns the regular Python REPL.

Here we're introducing more idiomatic way to test other custom REPLs in test_repl as necessary, without needing a pseudo-terminal.

CC @ZeroIntensity (mentorship): skip issue, skip news, needs backport to 3.13, needs backport to 3.14.

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Oct 18, 2025
@johnslavik johnslavik mentioned this pull request Oct 18, 2025
Open
@ZeroIntensity
Copy link
Member

ZeroIntensity commented Oct 18, 2025

I think it would be good if you created an issue for this.

@johnslavik johnslavik mentioned this pull request Oct 21, 2025
Closed
@johnslavik johnslavik changed the title Properly run the asyncio REPL in REPL tests gh-140438: Properly run the asyncio REPL in REPL tests Oct 21, 2025
@johnslavik
Copy link
Member Author

johnslavik commented Oct 21, 2025

I think it would be good if you created an issue for this.

@ZeroIntensity done; let's remove the skip issue label now so that the bot can do its job.

@johnslavik
Copy link
Member Author

johnslavik commented Oct 23, 2025

cc @asvetlov

@ZeroIntensity
Copy link
Member

ZeroIntensity commented Oct 23, 2025

@kumaraditya303 is our primary asyncio maintainer at the moment. Kumar, are you familiar enough with the asyncio REPL to review this?

kumaraditya303
kumaraditya303 approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnslavik johnslavik mentioned this pull request Oct 23, 2025
Draft
@kumaraditya303 kumaraditya303 merged commit 1a3da2c into python:main Oct 23, 2025
57 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 23, 2025

Thanks @bswck for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2025
@johnslavik @miss-islington
pythongh-140438: properly run the asyncio REPL tests (pythonGH-140298)
9117c34 
(cherry picked from commit 1a3da2c)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2025
@johnslavik @miss-islington
pythongh-140438: properly run the asyncio REPL tests (pythonGH-140298)
d21158a 
(cherry picked from commit 1a3da2c)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 23, 2025

GH-140507 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 23, 2025
@bedevere-app
Copy link

bedevere-app bot commented Oct 23, 2025

GH-140508 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 23, 2025
kumaraditya303 pushed a commit that referenced this pull request Oct 23, 2025
@miss-islington @johnslavik
[3.13] gh-140438: properly run the asyncio REPL tests (GH-140298) (#1…
adf0c11 
…40508)

gh-140438: properly run the asyncio REPL tests (GH-140298)
(cherry picked from commit 1a3da2c)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
kumaraditya303 pushed a commit that referenced this pull request Oct 23, 2025
@miss-islington @johnslavik
[3.14] gh-140438: properly run the asyncio REPL tests (GH-140298) (#1…
29c42cc 
…40507)

gh-140438: properly run the asyncio REPL tests (GH-140298)
(cherry picked from commit 1a3da2c)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 23, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.13 (tier-2) has failed when building commit adf0c11.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1396/builds/1697) and take a look at the build logs.
  4. Check if the failure is related to this commit (adf0c11) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1396/builds/1697

Failed tests:

  • test.test_multiprocessing_forkserver.test_processes

Failed subtests:

  • test_repr_rlock - test.test_multiprocessing_forkserver.test_processes.WithProcessesTestLock.test_repr_rlock

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1492, in test_repr_rlock
    self.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>'
- <RLock(SomeOtherThread, nonzero)>
+ <RLock(None, 0)>

@johnslavik johnslavik deleted the properly-run-asyncio-repl-in-repl-tests branch December 2, 2025 00:44
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@johnslavik @StanFromIreland
pythongh-140438: properly run the asyncio REPL tests (python#140298)
0491b53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnslavik @ZeroIntensity @bedevere-bot @kumaraditya303