gh-140652: fix can not list_all after _interpchannels.close#140656
Closed
yihong0618 wants to merge 1 commit intopython:mainfrom
Closed
gh-140652: fix can not list_all after _interpchannels.close#140656yihong0618 wants to merge 1 commit intopython:mainfrom
yihong0618 wants to merge 1 commit intopython:mainfrom
Conversation
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Member
|
I'm not an expert of this code. ids[i] = (struct channel_id_and_info){
.id = ref->cid,
.defaults = (struct _channeldefaults) {
.unboundop = -1,
.fallback = -1,
},
};
if (ref->chan != NULL) {
ids[i].defaults = ref->chan->defaults;
}For example, you can see def clean_up_channels():
for cid, _, _ in _channels.list_all():
try:
_channels.destroy(cid)
except _channels.ChannelNotFoundError:
pass # already destroyedThis method assumes that |
Contributor
Author
follow the doc I think list_all return active channels so do not return closed channels is right. |
Member
|
I'm not sure about it. We need someone else's opinion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the count should not be
*count = channels->numopen;because the channel may close after it close the ref->chan will be NULL
ref->chan == NULL