gh-143831: Compare cells by identity in forward references #143848
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Thank you for your interest in this! I encourage you to open a new issue if you think like the performance of Regarding why I solved it this way -- I just went with what the original intent was but with a corrected assumption about the hashability of cells. An alternative approach to hashing a sorted tuple of names -> cell ids is to simply return an identity of |
| and self.__forward_is_class__ == other.__forward_is_class__ | ||
| and self.__cell__ == other.__cell__ | ||
| # Two separate cells are always considered unequal in forward refs. | ||
| and self.__cell__ is other.__cell__ |
There was a problem hiding this comment.
This doesn't match the __hash__ since there we has the dictionary contents. So two different dicts with the same contents would hash equal, but not compare equal.
|
If the performance of some part of the typing stack is a problem for you, please open a concise issue with concrete examples of what you would like to change. (Digressions on the beauty of the wilds of Canada are not necessary.) |
Cells are mutable and, in regular comparison, they are equal when their contents are equal (or if both are empty).
Two different cells should not be considered equal by value in forward references, though.
If there are two separate cells, they either (1) target different variables or (2) belong to different scopes, so two separate forward references storing two separate cells are conceptually unequal even if these cells happen to be equal at a given point in time. Mutability, essentially.
I'm still working on tests.
TypeError: unhashable type: 'cell'#143831