gh-143672: Finish conversion of the struct module to Argument Clinic #143857
+349
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
reviewed
Jan 15, 2026
skirpichev
requested changes
Jan 16, 2026
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Member
Author
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I have updated docstrings. Please look if I missed something.
skirpichev
approved these changes
Jan 16, 2026
skirpichev
reviewed
Jan 16, 2026
| Struct.pack_into | ||
| buffer: Py_buffer(accept={rwbuffer}) | ||
| offset as offset_obj: object |
Member
There was a problem hiding this comment.
I think we should deprecate IndexError. OverflowError will be more meaningful here for, well, an overflow condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.