gh-143866: Verify return value of pathlib write methods in tests #143870
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
sobolevn
reviewed
Jan 15, 2026
| def test_write_bytes_return(self): | ||
| p = self.root / 'fileA' | ||
| data = b'some bytes' | ||
| self.assertEqual(len(data), p.write_bytes(data)) |
Member
There was a problem hiding this comment.
Can we update an existing test? Instead of creating a new one
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Author
|
Ok, i am changed it. Can you add "skip news" label please? |
sobolevn
reviewed
Jan 15, 2026
| # Check that trying to write bytes does not truncate the file. | ||
| self.assertRaises(TypeError, p.write_text, b'somebytes', encoding='utf-8') | ||
| self.assertEqual(self.ground.readbytes(p), b'\xe4bcdefg') | ||
| # check the return value |
Member
There was a problem hiding this comment.
Can we check the return value on line 79?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds assertions to ensure that
pathlib.Path.write_text()andpathlib.Path.write_bytes()correctly return the number of bytes written.Currently, the tests only verify the side effects (file content), which means a regression (like accidentally removing the
returnstatement) would go unnoticed.Linked Issue
Fixes #143866