gh-143874: Fix pdb expression result output stream in _exec_in_closure()
#143875
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where results of expressions executed via `_exec_in_closure()` were written to `sys.stdout` instead of the debugger output stream. Adds a regression test to ensure expression results are consistently emitted via pdb.stdout. Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
Contributor
|
I think the current test case doesn't actually test the remote debug mode. We need add some tests in cpython/Lib/test/test_remote_pdb.py Lines 832 to 833 in c461aa9 |
Contributor
|
Let's add some tests like this: class RemotePdbTestCase(unittest.TestCase):
...
def test_remote_closure_exec(self):
self.pdb._exec_in_closure('(lambda: 123)()', {}, {})
outputs = self.sockfile.get_output()
messages = [o['message'].strip() for o in outputs if 'message' in o]
self.assertIn("123", messages) |
Contributor
Author
Thank you very much — I couldn’t agree more with your feedback. Before that, I spent a long time trying to find an appropriate place for the corresponding test case, and still didn’t get it right. <(_ _)> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where results of expressions executed via
_exec_in_closure()were written tosys.stdoutinstead of the debugger output stream. Adds a regression test to ensure expression results are consistently emitted viapdb.stdout.