Skip to content

gh-143919: Reject control characters http cookies #143920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sethmlarson wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-143919: Reject control characters http cookies #143920

sethmlarson wants to merge 4 commits into from
+78 −7

Conversation

@sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Jan 16, 2026 •
edited by bedevere-app bot
Loading

@sethmlarson sethmlarson requested a review from gpshead January 16, 2026 17:33
@sethmlarson sethmlarson added type-security A security issue needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 16, 2026
@bedevere-app bedevere-app bot mentioned this pull request Jan 16, 2026
Open
johnslavik
johnslavik reviewed Jan 16, 2026
View reviewed changes
@sethmlarson @johnslavik
Apply suggestions from code review
03f222d 
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
sobolevn
sobolevn reviewed Jan 16, 2026
View reviewed changes
@sethmlarson @sobolevn
Apply suggestions from code review
6b999b5 
Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments

@johnslavik johnslavik johnslavik left review comments

@gpshead gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

awaiting review needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sethmlarson @sobolevn @johnslavik