Skip to content

gh-144012: Check null binary op extend #144014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fidget-Spinner merged 2 commits into from
Jan 18, 2026
Merged

gh-144012: Check null binary op extend #144014

Fidget-Spinner merged 2 commits into from
Jan 18, 2026
+14 −2

Conversation

@aisk
Copy link
Contributor

@aisk aisk commented Jan 18, 2026 •
edited by bedevere-app bot
Loading

@aisk aisk requested a review from markshannon as a code owner January 18, 2026 17:34
@aisk aisk requested review from Fidget-Spinner and removed request for markshannon January 18, 2026 17:34
@bedevere-app bedevere-app bot mentioned this pull request Jan 18, 2026
Open
Fidget-Spinner
Fidget-Spinner approved these changes Jan 18, 2026
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, does this need backporting?

@aisk
Copy link
Contributor Author

aisk commented Jan 18, 2026 •
edited
Loading

Thanks, does this need backporting?

I think it should, the 3.14 branch doesn’t check it either:

cpython/Python/bytecodes.c

Lines 825 to 826 in 23e3c0a

PyObject *res_o = d->action(left_o, right_o);
DECREF_INPUTS();

And 3.13 branch don't have this opcode, so we can just backport it to 3.14.

@aisk aisk added the needs backport to 3.14 bugs and security fixes label Jan 18, 2026
@Fidget-Spinner Fidget-Spinner merged commit 54bedcf into python:main Jan 18, 2026
79 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Jan 18, 2026

Thanks @aisk for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Jan 18, 2026

Sorry, @aisk and @Fidget-Spinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 54bedcf714160c3ecff3103a53f6291a7e1efd27 3.14

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Jan 18, 2026

@aisk can you please handle the backport? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees

@Fidget-Spinner Fidget-Spinner

Labels

needs backport to 3.14 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aisk @Fidget-Spinner