gh-144030: add check that argument is callable to Python version of functools.lru_cache #144031
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn
approved these changes
Jan 19, 2026
aisk
reviewed
Jan 19, 2026
| @@ -0,0 +1,3 @@ | |||
| The Python implementation of :func:`functools.lru_cache` differed from the | |||
| default C implementation in that it did not check that its argument is | |||
| callable. This discrepancy is now fixed and both raise a :class:`TypeError`. | |||
Contributor
There was a problem hiding this comment.
More specifically:
Suggested change
| callable. This discrepancy is now fixed and both raise a :class:`TypeError`. | |
| callable. This discrepancy is now fixed and both raise a :exc:`TypeError`. |
picnixz
reviewed
Jan 19, 2026
| return decorating_function | ||
|
|
||
| def _lru_cache_wrapper(user_function, maxsize, typed, _CacheInfo): | ||
| if not callable(user_function): |
Member
There was a problem hiding this comment.
Can we move this check in lru_wrapper directly? it should only be done in def decorating_function() I think.
We are doing the check twice otherwise (when we do not call the decorator with ())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C version has this check, the Python version doesn't so far. This PR makes the behaviours agree again
functools.lru_cachedoes not check that argument is callable #144030