gh-144050: Fix stat.filemode pure Python file type detection #144059
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please add a NEWS entry.
|
|
||
| def test_filemode_does_not_misclassify_random_bits(self): | ||
| # gh-144050 regression test | ||
| self.assertEqual(self.statmod.filemode(32767)[0], "?") |
Member
There was a problem hiding this comment.
I would use octals instead of decimals. Also, you need to test also the highest bit in a 16-bit number, so 0o177777.
| if mode & bit == bit: | ||
| perm.append(char) | ||
| break | ||
| if index == 0: |
Member
There was a problem hiding this comment.
See https://github.com/python/cpython/pull/108639/changes#r1309034276 . We can use opportunity to refactor this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a discrepancy between the C and pure Python implementations
of stat.filemode.
The pure Python implementation could misclassify arbitrary bit patterns
(e.g. 32767) as block devices. File type detection now correctly uses
(mode & S_IFMT) for file types, matching the C implementation.
A regression test is added to prevent this issue from recurring.
Fixes #144050
stat.filemode's C and Python implementation #144050