gh-142731: Prevent use-after-free in _PyObject_StoreInstanceAttribute with re-entrant __hash__#144636
Open
VanshAgarwal24036 wants to merge 1 commit intopython:mainfrom
Open
gh-142731: Prevent use-after-free in _PyObject_StoreInstanceAttribute with re-entrant __hash__#144636VanshAgarwal24036 wants to merge 1 commit intopython:mainfrom
VanshAgarwal24036 wants to merge 1 commit intopython:mainfrom
Conversation
…te and add regression test
bb74c9e to
22eb7a9
Compare
Member
|
What is the performance impact on this change? @kumaraditya303 hinted that this could add overhead (probably in free-threaded build) so I wpuld like that you first read the concerns on the issue before jumping on the PR. Serhiy also suggested an alternative. |
Member
|
FTR this could impact dataclass creations, namedtuple creations and other types that are dynamically created or that heavily use setattr/delattr explicitly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a potential use-after-free when storing or deleting instance attributes if a re-entrant
__hash__mutates the instance__dict__during attribute handling.Temporarily INCREF the managed dict in the
Py_GIL_DISABLEDpath to ensure it remains alive across the call tostore_instance_attr_dict().builtin_delattr_implandbuiltin_setattr_implvia re-entrant__hash__#142731