gh-66305: Fix a hang on Windows in the tempfile module#144672
Merged
serhiy-storchaka merged 7 commits intopython:mainfrom Feb 24, 2026
Merged
gh-66305: Fix a hang on Windows in the tempfile module#144672serhiy-storchaka merged 7 commits intopython:mainfrom
serhiy-storchaka merged 7 commits intopython:mainfrom
Conversation
…le module It occurred when trying to create a temporary file or subdirectory in a non-writable directory.
Member
Author
|
Reducing the number of attempts should help, but I have not tested yet. |
77ade1f to
ac17d9e
Compare
Member
Author
|
Tested on Windows. There was a test for readonly tempdir, but it was always skipped on Windows. It was not for a few seconds, but for about 10 days (for estimations). Now the test correctly works on Windows. |
Updated comment for clarity on temporary file conflict probability.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 24, 2026
…H-144672) It occurred when trying to create a temporary file or subdirectory in a non-writable directory. (cherry picked from commit ca66d3c40cd9ac1fb94dd7cd79ccb8fecf019527) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 24, 2026
|
GH-145168 is a backport of this pull request to the 3.14 branch. |
|
GH-145169 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 24, 2026
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It occurred when trying to create a temporary file or subdirectory in a non-writable directory.