gh-142837: Use semaphore accounting for multiprocessing.Queue.empty()#144832
Open
iamrajhans wants to merge 1 commit intopython:mainfrom
Open
gh-142837: Use semaphore accounting for multiprocessing.Queue.empty()#144832iamrajhans wants to merge 1 commit intopython:mainfrom
iamrajhans wants to merge 1 commit intopython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes gh-142837 by making
multiprocessing.Queue.empty()use the queue semaphore count (when available) instead of pipe readiness, so it aligns better withqsize()/full()behavior.What Changed
Lib/multiprocessing/queues.pyQueue.empty()to:self._sem.get_value() == self._maxsizewhensem_getvalue()is availablenot self._poll()whensem_getvalue()is unavailable (e.g. macOS)empty()may raiseOSError.Lib/test/_test_multiprocessing.pytest_empty_uses_semaphore_countto verifyempty()is driven by semaphore accounting rather than pipe poll state when supported.Doc/library/multiprocessing.rstget_nowait().Queue.empty().versionchanged:: 3.15note for semaphore-basedempty()behavior.Why
Queue.empty()previously relied on pipe readiness, which could report empty while items were already accounted for in queue size/semaphore state. This caused asymmetric behavior versusqsize()/full()and surprising results under load.📚 Documentation preview 📚: https://cpython-previews--144832.org.readthedocs.build/