gh-61448: Fix inspect.formatargvalues for deleted arguments#144854
Open
RoryGlenn wants to merge 1 commit intopython:mainfrom
Open
gh-61448: Fix inspect.formatargvalues for deleted arguments#144854RoryGlenn wants to merge 1 commit intopython:mainfrom
RoryGlenn wants to merge 1 commit intopython:mainfrom
Conversation
Fix inspect.formatargvalues() to handle arguments that are no longer bound in the frame locals (e.g. after 'del') by showing them as <deleted> instead of raising KeyError. This applies to regular arguments, *args, and **kwargs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
inspect.formatargvalues()to handle arguments that are no longer bound in the frame locals (e.g. afterdel) by showing them as<deleted>instead of raisingKeyError.Changes
_DELETEDsentinel object withreprof<deleted>inLib/inspect.pyformatargvalues()to uselocals.get(name, _DELETED)instead oflocals[name]for regular arguments,*args, and**kwargs*args/**kwargsReproducer (before fix)
After fix
Note: This supersedes the stale PR #101318 which has been awaiting changes since August 2023 with merge conflicts.