gh-141510: Use frozendict in the stdlib#144909
Conversation
Co-authored-by: Donghee Na <donghee.na@python.org>
|
This PR only changes private names, so it should not impact stdlib users. |
|
If this change is merged, I will propose a follow-up PR which modify public names. |
AlexWaygood
left a comment
There was a problem hiding this comment.
One optional suggestion in typing.py
picnixz
left a comment
There was a problem hiding this comment.
Ok for ssl and a suggestion for opcode
| _cache_format = { | ||
| "LOAD_GLOBAL": { | ||
| _cache_format = frozendict( | ||
| LOAD_GLOBAL={ |
There was a problem hiding this comment.
The values of LOAD_GLOBAL can also be a frozendict (that is, we can have nested frozendicts).
|
The SC does not allow mechanically replacing all uses of dict. Please wait for reviews from the code owners of each module. |
|
What's the benefit of changing this in e.g. typing.py? It might break some users who modify this dict. That's not a supported use case, but we shouldn't go out of our way to break users unless there's some benefit. |
Uh oh!
There was an error while loading. Please reload this page.