gh-141510: Optimize {frozen}dict.fromkeys for frozendict#144915
Open
corona10 wants to merge 8 commits intopython:mainfrom
Open
gh-141510: Optimize {frozen}dict.fromkeys for frozendict#144915corona10 wants to merge 8 commits intopython:mainfrom
corona10 wants to merge 8 commits intopython:mainfrom
Conversation
vstinner
reviewed
Feb 17, 2026
kumaraditya303
approved these changes
Feb 17, 2026
vstinner
reviewed
Feb 17, 2026
methane
reviewed
Feb 17, 2026
| PyObject *d; | ||
| int status; | ||
|
|
||
| d = _PyObject_CallNoArgs(cls); |
Member
There was a problem hiding this comment.
If d is a newly created object, whether it's a dict or a frozendict, wouldn't it be unnecessary to lock it?
If we consider the possibility that d might leak to another thread for some reason, wouldn't it be necessary to lock it even in the case of a frozendict?
class D(frozendict):
def __new__(cls):
return frozendict({"a":1, "b":2})
d = D.fromkeys("def")
print(d)
# frozendict({'a': 1, 'b': 2, 'd': None, 'e': None, 'f': None})In this case, d is exact frozendict, but d can be leaked to other thread.
Member
Author
There was a problem hiding this comment.
I think we could remove the lock for d, but since it has been locked before, would it make sense to test this in a separate PR?
Member
There was a problem hiding this comment.
I don't think that other threads can access d during fromkeys() call.
D.fromkeys() calls dict.fromkeys() and dict.__new__(): the return type is dict, not D.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.